-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New version: Oracle.JDK.17 version 17.0.8 #112813
New version: Oracle.JDK.17 version 17.0.8 #112813
Conversation
/AzurePipelines run |
Azure Pipelines successfully started running 1 pipeline(s). |
jacobgelling, The check-in policies require a moderator to approve PRs from the community. Our moderators are community volunteers, please be patient and allow them sufficient time to review your submission. Template: msftbot/requiresApproval/moderator |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
After committing the suggested changes, you would also have to rename the version folder to match the new PackageVersion. The folder under manifests/o/Oracle/JDK/17
should be renamed from 17.0.8
-> 17.0.8.0
A quick and easy way to do this would be here in GitHub Web by pressing the . (dot) key on your keyboard that'll open up the PR in VS Code Online. Navigate to Explorer menu, find the required folder and make the appropriate rename changes.
After that, stage and commit your changes from Source Control menu on the left. (The changes are automatically pushed)
manifests/o/Oracle/JDK/17/17.0.8/Oracle.JDK.17.locale.en-US.yaml
Outdated
Show resolved
Hide resolved
Hello @jacobgelling, The package manager bot determined changes have been requested to your PR. Template: msftbot/changesRequested |
Head branch was pushed to by a user without write access
/AzurePipelines run |
No commit pushedDate could be found for PR 112813 in repo microsoft/winget-pkgs |
/AzurePipelines run |
No commit pushedDate could be found for PR 112813 in repo microsoft/winget-pkgs |
/AzurePipelines run |
Azure Pipelines successfully started running 1 pipeline(s). |
@jacobgelling Please mark the above conversations as "resolved" for auto-merge process to merge this PR after the pipeline checks pass |
Hello jacobgelling, Template: msftbot/validationCompleted |
Hello jacobgelling, Template: msftbot/validationCompleted |
Hello jacobgelling, Template: msftbot/validationCompleted |
|
Hello jacobgelling, Template: msftbot/validationCompleted |
Publish pipeline succeeded for this Pull Request. Once you refresh your index, this change should be present. |
winget validate --manifest <path>
?winget install --manifest <path>
?Note:
<path>
is the name of the directory containing the manifest you're submitting.Microsoft Reviewers: codeflow:open?pullrequest=#112813